Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Aug 13, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@thirdweb-dev/[email protected]

Patch Changes

[email protected]

Patch Changes

@thirdweb-dev/[email protected]


PR-Codex overview

This PR focuses on updating version numbers across several packages and adding new changelog entries for the updates made, particularly highlighting a fix in the thirdweb package.

Detailed summary

  • Deleted the file .changeset/many-tips-fail.md.
  • Updated version in packages/thirdweb/package.json from 5.105.32 to 5.105.33.
  • Updated version in packages/nebula/package.json from 0.2.32 to 0.2.33.
  • Updated version in packages/wagmi-adapter/package.json from 0.2.129 to 0.2.130.
  • Added changelog entry for packages/nebula at version 0.2.33, noting dependency updates.
  • Added changelog entry for packages/thirdweb at version 5.105.33, mentioning a fix for onDisconnect in React Native.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where onDisconnect was not triggered on React Native.
  • Chores

    • Bumped versions: nebula to 0.2.33, thirdweb to 5.105.33, wagmi-adapter to 0.2.130.
    • Performed minor maintenance cleanup.
  • Documentation

    • Updated changelogs to reflect the latest patch releases.

@joaquim-verges joaquim-verges requested review from a team as code owners August 13, 2025 01:20
@vercel
Copy link

vercel bot commented Aug 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
docs-v2 Ready Preview Comment Aug 13, 2025 1:45am
nebula Ready Preview Comment Aug 13, 2025 1:45am
thirdweb_playground Ready Preview Comment Aug 13, 2025 1:45am
thirdweb-www Ready Preview Comment Aug 13, 2025 1:45am
wallet-ui Ready Preview Comment Aug 13, 2025 1:45am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 13, 2025

Walkthrough

Repository updates include deletion of a changeset file, addition of changelog entries, and patch version bumps for nebula (0.2.33), thirdweb (5.105.33), and wagmi-adapter (0.2.130). No source code or public API changes are present.

Changes

Cohort / File(s) Summary of changes
Changeset cleanup
.changeset/many-tips-fail.md
Deleted changeset file.
Nebula release bump
packages/nebula/CHANGELOG.md, packages/nebula/package.json
Added 0.2.33 changelog (dependency update to [email protected]); bumped version 0.2.32 → 0.2.33.
Thirdweb release bump
packages/thirdweb/CHANGELOG.md, packages/thirdweb/package.json
Added 5.105.33 changelog noting React Native onDisconnect fix; bumped version 5.105.32 → 5.105.33.
Wagmi-adapter release bump
packages/wagmi-adapter/CHANGELOG.md, packages/wagmi-adapter/package.json
Added 0.2.130 changelog header; bumped version 0.2.129 → 0.2.130.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

packages, SDK

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch changeset-release/main

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app
Copy link
Contributor

graphite-app bot commented Aug 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Aug 13, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
packages/nebula/CHANGELOG.md (1)

3-9: Changelog entry aligns with dependency bump; consider linking the upstream fix for context.

Looks good as a release note for a dependency update. Optionally add a sub-bullet linking to thirdweb 5.105.33 changelog to surface the RN onDisconnect fix context for consumers.

Apply this diff if you want to include a reference:

 ## 0.2.33

 ### Patch Changes

 - Updated dependencies [[`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d)]:
   - [email protected]
+  - Note: includes fix for React Native onDisconnect not being invoked. See thirdweb changelog for details.
packages/wagmi-adapter/CHANGELOG.md (1)

3-4: Version header added; optional note for clarity.

The empty section is consistent with past entries. If helpful for users, add a single line indicating “no user-facing changes.”

 ## 0.2.130
+No user-facing changes. Version bump only.
packages/thirdweb/CHANGELOG.md (1)

3-8: Nit: Capitalize “React Native” and wrap the method name in backticks for consistency

Other entries capitalize React Native and wrap identifiers in backticks. Align this entry for consistency and readability.

- - [#7850](https://github.com/thirdweb-dev/js/pull/7850) [`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix onDisconnect not being invoked in react native
+ - [#7850](https://github.com/thirdweb-dev/js/pull/7850) [`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix `onDisconnect` not being invoked in React Native
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4be655d and bfa4045.

📒 Files selected for processing (7)
  • .changeset/many-tips-fail.md (0 hunks)
  • packages/nebula/CHANGELOG.md (1 hunks)
  • packages/nebula/package.json (1 hunks)
  • packages/thirdweb/CHANGELOG.md (1 hunks)
  • packages/thirdweb/package.json (1 hunks)
  • packages/wagmi-adapter/CHANGELOG.md (1 hunks)
  • packages/wagmi-adapter/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .changeset/many-tips-fail.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**

📄 CodeRabbit Inference Engine (CLAUDE.md)

Wagmi ecosystem integration is in packages/wagmi-adapter/

Files:

  • packages/wagmi-adapter/CHANGELOG.md
  • packages/wagmi-adapter/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`

Applied to files:

  • packages/wagmi-adapter/CHANGELOG.md
  • packages/wagmi-adapter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: Size
  • GitHub Check: Unit Tests
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/nebula/package.json (1)

60-60: Nebula version bump is consistent with changelog and workspace dependency.

No issues spotted. The dependency on thirdweb via workspace is aligned with the upstream 5.105.33 release.

packages/thirdweb/package.json (1)

412-412: thirdweb patch bump acknowledged; peer ranges remain compatible.

The 5.105.33 version aligns with the changelog entry (RN onDisconnect fix). No export or peer dependency changes—LGTM.

packages/wagmi-adapter/package.json (1)

58-58: wagmi-adapter version bump looks good; peer ranges are compatible.

  • thirdweb peer: ^5.85.0 covers 5.105.33.
  • @wagmi/core peer: ^2.16.0 covers dev dep 2.17.3.

No other changes—LGTM.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.06 KB (0%) 1.3 s (0%) 151 ms (+87.9% 🔺) 1.5 s
thirdweb (cjs) 357.05 KB (0%) 7.2 s (0%) 575 ms (-4.39% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 44 ms (+539.35% 🔺) 158 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 10 ms (+525.22% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 33 ms (+145.26% 🔺) 416 ms

@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.34%. Comparing base (4be655d) to head (bfa4045).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7851   +/-   ##
=======================================
  Coverage   56.34%   56.34%           
=======================================
  Files         905      905           
  Lines       58834    58834           
  Branches     4152     4150    -2     
=======================================
  Hits        33151    33151           
  Misses      25577    25577           
  Partials      106      106           
Flag Coverage Δ
packages 56.34% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants