-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #7851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #7851
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughRepository updates include deletion of a changeset file, addition of changelog entries, and patch version bumps for nebula (0.2.33), thirdweb (5.105.33), and wagmi-adapter (0.2.130). No source code or public API changes are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry aligns with dependency bump; consider linking the upstream fix for context.Looks good as a release note for a dependency update. Optionally add a sub-bullet linking to thirdweb 5.105.33 changelog to surface the RN onDisconnect fix context for consumers.
Apply this diff if you want to include a reference:
## 0.2.33 ### Patch Changes - Updated dependencies [[`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d)]: - [email protected] + - Note: includes fix for React Native onDisconnect not being invoked. See thirdweb changelog for details.packages/wagmi-adapter/CHANGELOG.md (1)
3-4: Version header added; optional note for clarity.The empty section is consistent with past entries. If helpful for users, add a single line indicating “no user-facing changes.”
## 0.2.130 +No user-facing changes. Version bump only.packages/thirdweb/CHANGELOG.md (1)
3-8: Nit: Capitalize “React Native” and wrap the method name in backticks for consistencyOther entries capitalize React Native and wrap identifiers in backticks. Align this entry for consistency and readability.
- - [#7850](https://github.com/thirdweb-dev/js/pull/7850) [`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix onDisconnect not being invoked in react native + - [#7850](https://github.com/thirdweb-dev/js/pull/7850) [`4be655d`](https://github.com/thirdweb-dev/js/commit/4be655dd084dd474d021a7a539a0c67e648bb42d) Thanks [@joaquim-verges](https://github.com/joaquim-verges)! - Fix `onDisconnect` not being invoked in React Native
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.changeset/many-tips-fail.md(0 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (1)
- .changeset/many-tips-fail.md
🧰 Additional context used
📓 Path-based instructions (1)
packages/wagmi-adapter/**
📄 CodeRabbit Inference Engine (CLAUDE.md)
Wagmi ecosystem integration is in
packages/wagmi-adapter/
Files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
🧠 Learnings (1)
📚 Learning: 2025-07-18T19:19:55.613Z
Learnt from: CR
PR: thirdweb-dev/js#0
File: CLAUDE.md:0-0
Timestamp: 2025-07-18T19:19:55.613Z
Learning: Applies to packages/wagmi-adapter/** : Wagmi ecosystem integration is in `packages/wagmi-adapter/`
Applied to files:
packages/wagmi-adapter/CHANGELOG.mdpackages/wagmi-adapter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Size
- GitHub Check: Unit Tests
- GitHub Check: Lint Packages
- GitHub Check: Build Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/nebula/package.json (1)
60-60: Nebula version bump is consistent with changelog and workspace dependency.No issues spotted. The dependency on thirdweb via workspace is aligned with the upstream 5.105.33 release.
packages/thirdweb/package.json (1)
412-412: thirdweb patch bump acknowledged; peer ranges remain compatible.The 5.105.33 version aligns with the changelog entry (RN onDisconnect fix). No export or peer dependency changes—LGTM.
packages/wagmi-adapter/package.json (1)
58-58: wagmi-adapter version bump looks good; peer ranges are compatible.
- thirdweb peer: ^5.85.0 covers 5.105.33.
- @wagmi/core peer: ^2.16.0 covers dev dep 2.17.3.
No other changes—LGTM.
size-limit report 📦
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7851 +/- ##
=======================================
Coverage 56.34% 56.34%
=======================================
Files 905 905
Lines 58834 58834
Branches 4152 4150 -2
=======================================
Hits 33151 33151
Misses 25577 25577
Partials 106 106
🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@thirdweb-dev/[email protected]
Patch Changes
4be655d]:[email protected]
Patch Changes
4be655dThanks @joaquim-verges! - Fix onDisconnect not being invoked in react native@thirdweb-dev/[email protected]
PR-Codex overview
This PR focuses on updating version numbers across several packages and adding new changelog entries for the updates made, particularly highlighting a fix in the
thirdwebpackage.Detailed summary
.changeset/many-tips-fail.md.packages/thirdweb/package.jsonfrom5.105.32to5.105.33.packages/nebula/package.jsonfrom0.2.32to0.2.33.packages/wagmi-adapter/package.jsonfrom0.2.129to0.2.130.packages/nebulaat version0.2.33, noting dependency updates.packages/thirdwebat version5.105.33, mentioning a fix foronDisconnectin React Native.Summary by CodeRabbit
Bug Fixes
Chores
Documentation